search

urbdyn / rules_fish

Bazel toolchain rules for Fish shell.
Apache License 2.0
2 stars 0 forks source link

Add MacOS Support #9

Open Matthew-Benson opened 1 month ago

Matthew-Benson commented 1 month ago

The fish_binary probably works for MacOS today, but the toochain hasn't been configured for MacOS platforms. This needs added (it's currently commented out) and tested.

Matthew-Benson commented 1 month ago

Ah, today this fails due to bad toolchain resolution for ninja, and this is resolved in a PR (here), but it's ahead of the current release and it's not clear when we'll get a release.

That leaves us with a couple questions.

  1. Why is a bzlmod dependency on rules_foreign_cc automatically registering a toolchain for ninja? We should try to address this and remove this toolchain registration if possible. Apparently bzlmod support isn't great, which makes this a lot harder on us downstream.
  2. Does this only affect m1/m2 Macs? Can we defer the issue? Will the rust toolchain have any issues when fish 3.8 releases?

I think we should defer this issue for now. We can address MacOS support more easily when upstream issues are resolved.

Matthew-Benson commented 1 month ago

There's also a radical third option. We could vendor a fork of rules_foreign_cc using Copybara that only includes the toolchain for cmake so we never introduce this dependency on rules_foreign_cc to library consumers.