Open ashelkovnykov opened 3 months ago
No idea why the linter is whining. Everything builds, tests, and lints fine on my end using cargo 1.77.0 (3fe68eabf 2024-02-29)
.
@ashelkovnykov I just opened #223 so we can have in-sync rust versions between CI and devs without forcing Nix on people.
%mean
hint processing in+mook
. They were disabled around November of last year when they caused issues with booting pills.%mean
hint processing in+mook
(variable name shadowing issue - we were using the wrongcell
var)signal_hook
crate for processing SIGINTs with a flag that was checked on Nock2
,9
, and11
. We nowmprotect()
the entireNockStack
memory arena onSIGINT
and gracefully recover from the resultingSIGSEGV
.Resolves #144 & #152
Note: I don't think that the double-tap case of
SIGINT
is being handled fully correctly right now, but it's difficult for me to check because of the machine from which I need to work on for now. Would appreciate whomever reviews this PR to play around with sendingSIGINT
s viaCtrl + C
and compare to the ergonomics of doing so in Vere. Otherwise, I'll get to it on April 1, once I have my regular work machine back in action.