pma: fix memory corruption restoration bug

urbit / ares

The new runtime for Urbit

MIT License

81 stars 13 forks source link

pma: fix memory corruption restoration bug #226

Closed barter-simsum closed 2 months ago

barter-simsum commented 2 months ago

Previously, we failed to record node partitions in the flist on restore - leading to memory corruption. Now we do so.

btest.c for some reason ran without fault despite this bug. But when running ares as a serf of vere, this would routinely cause crashes in restoration. I've confirmed this PR fixes that and restoration seems to be behaving normally.

barter-simsum commented 2 months ago

I may refactor this a bit as the dependency graph on restore is pretty complicated and could probably be simplified. Perhaps in a different PR

barter-simsum commented 2 months ago

PS. Please don't merge yet. Confirming this fix doesn't introduce any memory leaks in the backing file.