search

urbit / arvo

https://github.com/urbit/urbit
110 stars 57 forks source link

add .DS_Store to .gitignore #1165

Closed jfranklin9000 closed 5 years ago

jfranklin9000 commented 5 years ago

yep, i'm a mac user

Fang- commented 5 years ago

Pretty sure you want to add it to your global .gitignore instead? I don't think repo-specific .gitignores should concern themselves with OS or editor files (unless the repo is only usable by one specific editor).

jtobin commented 5 years ago

I'm inclined to agree with @Fang- here. I don't have terribly strong opinions on what ought go in a project's .gitignore, but arvo's is pretty minimal as-is, so for hygienic purposes we might as well keep it that way and restrict entries to be project- -- rather than contributor- -- specific.

(By that logic of course we can just gut the whole .gitignore file as-is, since I believe the only project-specific entry in there is no longer relevant.)

jfranklin9000 commented 5 years ago

OK, I added it to my global .gitignore.

ohAitch commented 5 years ago

+1: .gitignore is for files reader by tools included/referenced in the repo (*.o node_modules etc), .git/info/exclude and ~/.gitignore are for file-browser editor backup etc artefacts.

On Thursday, 9 May 2019, jfranklin9000 notifications@github.com wrote:

Closed #1165 https://github.com/urbit/arvo/pull/1165.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/urbit/arvo/pull/1165#event-2330066727, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOFPBVLJDRI346NKDK6JBTPUQJX7ANCNFSM4HLWXSQA .