search

urbit / azimuth

General-purpose PKI on Ethereum
MIT License
134 stars 36 forks source link

Contracts/addresses not in sync with those deployed #52

Open mikegogulski opened 2 years ago

mikegogulski commented 2 years ago

Since the deployment of the new 0x33EeCbf908478C10614626A9D304bfe18B78DD73 contract as ecliptic.eth a few days ago, there have been no OpenSea sales of stars/planets, because OpenSea's /assets/urbit-id URL still points at the old 0xa5 contract. They do have a new /assets/azimuth-points-v2 URL that references points via the new contract, but there's no activity there, either. Anyway, that's a different-though-related issue, and I have a ticket (#141974) open with them on it, as well as ticket 265 with Tlon.

The issue for this ticket is that the README doesn't reflect the new Ecliptic address (and possibly others idk), and the new Ecliptic contract isn't present in the /contracts directory. This makes it somewhat tricky for people to track what's happened across an upgrade. It's of course understandable that the most recent Ecliptic contract couldn't be posted here before deployment since it was a security fix, but the ecliptic.eth address shown in the README is at least 2 versions old.

Fang- commented 2 years ago

We've already reached out to Opensea about this issue on their end.

The latest upgrade is described in #51 and should get merged as soon as we get a second confirmation that the code in that PR matches what's on chain right now.

Thanks for the heads up about the readme, I'll patch that shortly.