search

urbit / bitcoin-wallet

Repository for issue triaging and (eventually) the bitcoin wallet code
MIT License
4 stars 1 forks source link

When clicking "Replace Wallet", there is no confirmation dialogue box for an irreversible action #22

Open ynx0 opened 3 years ago

ynx0 commented 3 years ago

I clicked "Replace Wallet", thinking that it would prompt me for further action but instead I was booted back to the screen which asks for a provider. I wasn't actually trying to replace it, and also didn't know what that meant, so I wanted to "undo" the action but there was no way to do that.

Having a simple "Are you sure you want to replace your wallet?" window, along with a link to some section in the urbit.org btc wallet docs about what this means would probably be more than enough

urcades commented 3 years ago

Hello — addressing this issue took a bit of restructuring how we handle modal windows in the wallet, but I'm enjoying how it ended up:

Frame 2

Basically, clicking the "replace wallet" item in settings (which is now located near the bottom, because it has big implications for the rest of the wallet experience) prompts a modal interface which doesn't immediately overwrite or replace/remove the wallet. One could back out of this interface by clicking "Cancel) at any time, and their wallet will remain intact.

From this point, someone can simply choose to use their master ticket/any wallet seed, or Bridge to derive an XPub address and resulting wallet.

Check out the designs here:

https://www.figma.com/file/zRsxdDMVZ8LVTAwsHpai64/Bitcoin-Wallet?node-id=1255%3A299

cc @jalehman