urbit / bridge

An application for interacting with Azimuth.
MIT License
96 stars 25 forks source link

login: Metamask login flow does not set wallet type #1007

Open tomholford opened 2 years ago

tomholford commented 2 years ago

Discovered this issue while investigating #1006. In short, each login flow should set the walletType at the time of login, so that future delegations to the wallet (e.g., signing and sending) use the corresponding methods for a given wallet type.

However, it seems that it is not being set for Metamask / Brave Wallet (note in the below screenshot, it's being set for other wallet types as I clicked through them, but not MM).

image

The downstream effect of this is that sometimes when logging in with MM, it fails with the following error:

image