search

urbit / bridge

An application for interacting with Azimuth.
MIT License
95 stars 25 forks source link

NetworkKeys: actually fix stale keyfile download #1072

Closed pkova closed 1 year ago

pkova commented 1 year ago

My previous PR #1069 fixed the stale keyfile download issue #1068, but introduced a race condition where sometimes the point state would update prematurely, leading to the rekey never completing in the UI.

On deeper investigation I found out that the stale keyfile bug was introduced by me in #1052 when I misunderstood and changed the checkForUpdates function. This PR reverts the relevant changes in #1069 and #1052, fixing #1068 once and for all.

tomholford commented 1 year ago

@pkova Thanks for the fix. Was this tested on mainnet?

pkova commented 1 year ago

Yes.