urbit / bridge

An application for interacting with Azimuth.
MIT License
94 stars 25 forks source link

Cannot use hardware wallet on desktop when browser window is small #547

Open ynx0 opened 3 years ago

ynx0 commented 3 years ago

When on a desktop, a user cannot use a hardware wallet to authenticate if their browser is too small, presumably because the detection is done solely based on browser window dimensions rather than user agent.

urbit bridge bug

A cursory glance at the code reveals these points of interest:

the last of which is based on https://usehooks.com/useMedia/ , which is based on screen size.

react-device-detect is a possible library to replace this functionality that wraps detection functionality based on user-agent and some other browser metadata.

Fang- commented 3 years ago

Good catch! Wondering why we marked those as unsupported on mobile, in any case. Wouldn't be too surprised if those are supported by some mobile browsers now...