urbit / bridge

An application for interacting with Azimuth.
MIT License
98 stars 25 forks source link

Clicking on Accept an Incoming point doesn't close the message #938

Closed yosoyubik closed 2 years ago

yosoyubik commented 2 years ago

Describe the bug: Accepting a transfer doesn't remove the "Incoming point" message, so the user might think that the transfer was not successful, click multiple times, which will send extra L2 txs that will later fail (and show up as such in the tx history). Note here that one of them will go through, and the others will fail—nonce here is probably reused—so this is only confusing UX/UI rather than an actual bug.

To reproduce: Steps to reproduce the behavior:

  1. Transfer a planet to an ETH address
  2. Log in with that ETH address
  3. Click on Accept multiple times
  4. Click on History to see the Tx failures

Expected behavior: After clicking on Accept, the "Incoming point" message should go away, after checking with the Roller that the TX is now in pending

Screenshot or console log:

Screen Shot 2022-02-04 at 5 06 02 PM Screen Shot 2022-02-04 at 5 04 15 PM

Ethereum network: Ropsten

Desktop (please complete the following information):

Login method: Master Ticket