Bridge reports more invite codes than issued

[yapishu]

Describe the bug: After migrating ~matwet's spawn proxy, I attempted to generated the reported maximum weekly number of planet codes. The UI told me this was 25 invites (x4 for 100 signatures), and I began signing transactions.

After generating 16 invitation codes, the interface reported that I had reached the weekly maximum and I was prevented from signing more transactions. The 'Invitation' modal showed 16 planet codes.

After signing out and back into Bridge, I noticed 26 planet codes were reported available, and the modal showed the 10 L1 planets that I had already distributed as L2 invitation codes, spinning forever without generating codes. This was resolved by @tomholford with issue 932.

However, I now see 25 invitation codes reported available. I don't believe this is accurate, since I don't think I finished signing 100 transactions (it felt closer to half that but I wasn't counting). @tomholford told me that the backend reported 25 planet codes as having been issued.

This leads me to believe that 9 of the planet codes listed as available are not valid. However, I don't know how to confirm or test this without potentially burning them.

To reproduce: Steps to reproduce the behavior:

• Attempt to issue 25 planets
• Sign all transactions until you are alerted that you've reached the maximum
• Sign out and back into Bridge
• View invitation screen

Expected behavior: Invite code modal should report the number of L2 codes generated that are signed and available rather than the number initially submitted.

Screenshot or console log: Console log available on request.

Ethereum network: Mainnet

Desktop:

• OS: Ubuntu 20.04
• Browser: Brave

Login method: Trezor Model T via MetaMask 0x2dfcb38f4c06f0b26bb62da3c68675971bdac274

[yapishu]

Minor update: still having issues with Bridge after the launch; it continues to report planets that were previously spawned on L1 in my invitate code list, and two times this evening I stopped getting requests for signatures halfway though generating batches -- this might have been a Trezor/Metamask issue but I'm afraid that interrupting the signature process (painstaking with a Trezor) seems to throw it off, and make it overreport the number of planets that have actually been spawned.

Last time I signed into the beta Bridge, it was reporting 26 planets; when I signed into Bridge tonight, it reported 29. After a few attempts at generating planet codes, it's now up to 39, though I'm pretty sure I only successfully completed signatures for 6 or 7 spawns. I think it's counting the total sum of attempts I created.

I also noticed it reports these planets in my inventory when I sign in, which I haven't seen before:

I assume these are L2 planets I attempted to spawn since they're under my star and have no history on network.urbit.og but I'm not sure.

Edit: signed back in and it reports 29 codes; click back to main menu and click invite codes again and it reports 38; click back again and it report 39.

[arthyn]

@yapishu When you see this, do you see all the codes as actual links or is it just showing the ship names? I think it puts all potential spawns on that screen first and then it starts to run through them to remove any that have either been claimed or aren't actual invites. I'm in the middle of changing how this works so it just builds the list one by one instead.

[yapishu]

@arthyn I think if I leave it alone and let it settle for a bit it settles down at 29, and shows codes for all of them. When it reports higher numbers it just shows the names and spinner for the extra ones. Let me know if I can help with testing anything!