search

urbit / create-landscape-app

Get started making a simple app for Landscape with a few commands.
86 stars 21 forks source link

full: better layout of the content div #26

Closed jfranklin9000 closed 4 years ago

jfranklin9000 commented 4 years ago

This PR doesn't have the contents of https://github.com/urbit/create-landscape-app/pull/25 but I think it can be pulled cleanly after that one.

When you have screen width such that h-100-minus-40-s comes into play the layout breaks (the content border disappears and some margin or padding in the header is lost), but that was true before so I won't worry about it.

jfranklin9000 commented 4 years ago

Some screenshots:

before

content should fit, scrolled up

before-content-fit-scrolled-up

content should fit, scrolled down

before-content-fit-scrolled-down

content doesn't fit, scrolled up

before-content-no-fit-scrolled-up

content doesn't fit, scrolled down

before-content-no-fit-scrolled-down

after

content fits, no scrollbar

after-content-fit-no-scroll

content doesn't fit, scrolled up

after-content-no-fit-scrolled-up

content doesn't fit, scrolled down

after-content-no-fit-scrolled-down
matildepark commented 4 years ago

When you have screen width such that h-100-minus-40-s comes into play the layout breaks (the content border disappears and some margin or padding in the header is lost), but that was true before so I won't worry about it.

This is actually on purpose, we remove the OS1 chrome for mobile layout.