urbit / create-landscape-app

Get started making a simple app for Landscape with a few commands.
86 stars 21 forks source link

TypeError in landscape home page on fake ship #47

Closed pilwex-migsun closed 4 years ago

pilwex-migsun commented 4 years ago

After running a fresh app created by CLA on a fake ship (|start %appname), an error appears in home page in landscape.

Screenshot from 20

Also, the icons in app's page do not show correctly.

Screenshot from 2020

output:

TypeError: No[e] is not a function at Icon (http://localhost:8081/~landscape/js/bundle/index.4c5a7f72912cc668f0e5.js:364:108223) at Za (http://localhost:8081/~landscape/js/bundle/index.4c5a7f72912cc668f0e5.js:319:57929) at gs (http://localhost:8081/~landscape/js/bundle/index.4c5a7f72912cc668f0e5.js:319:104168) at cl (http://localhost:8081/~landscape/js/bundle/index.4c5a7f72912cc668f0e5.js:319:96716) at sl (http://localhost:8081/~landscape/js/bundle/index.4c5a7f72912cc668f0e5.js:319:96641) at Qs (http://localhost:8081/~landscape/js/bundle/index.4c5a7f72912cc668f0e5.js:319:93671) at http://localhost:8081/~landscape/js/bundle/index.4c5a7f72912cc668f0e5.js:319:45313 at t.unstable_runWithPriority (http://localhost:8081/~landscape/js/bundle/index.4c5a7f72912cc668f0e5.js:327:3844) at Bi (http://localhost:8081/~landscape/js/bundle/index.4c5a7f72912cc668f0e5.js:319:45022) at Vi (http://localhost:8081/~landscape/js/bundle/index.4c5a7f72912cc668f0e5.js:319:45258)

system: Linux64 MacOS urbit 0.10.8

To reproduce:

matildepark commented 4 years ago

This isn't a CLA bug; it's a bug with urbit/urbit and how third-party apps function on the current boot pill.

In indigo-react, the Icon component now crashes if passed no key, I believe; on livenet, this is fixed in https://github.com/urbit/urbit/commit/a2fbf8c51c0914b212bf74d1fcff7195d914e2fa. The boot pill precedes this commit, so it retains the bug. It only affects ships with third-party applications.

If you boot your fake ship with the current master branch's pkg/arvo this issue is resolved. You can also just directly go to http://localhost:9000/~appname to sidestep this.

eg. ./urbit -F zod -B "bin/solid.pill" -A "pkg/arvo" from the urbit repo directory, assuming git lfs install and git lfs pull have been run to get the pill blobs.