search

urbit / developers.urbit.org

Website for the Urbit Foundation's developer program
https://developers.urbit.org
15 stars 56 forks source link

wallet generator glossary is confusing #141

Open drbeefsupreme opened 3 years ago

drbeefsupreme commented 3 years ago

https://urbit.org/docs/glossary/wallet-generator/

This was raised by someone in UC, but since I didn't immediately file an issue I don't remember who.

The page says "The Wallet Generator is a planned open-source app developed for generating an Urbit HD Wallet to secure your Azimuth identities. "

To the best of my knowledge, nobody is working on this right now. But there is an Urbit wallet generator https://github.com/urbit/urbit-wallet-generator that is marked as deprecated, but definitely still works.

The timeline of this is confusing. The wallet generator is ~2 years old, the glossary is ~18 months old, and the wallet generator was only marked deprecated 6 months ago. Since the glossary was started before I came to Tlon, I don't know if this entry was written before the wallet generator app was finished, and the "planned wallet generator app" was referring to the one that actually already exists, or if it is referring to whatever will be replacing the deprecated one.

So the entry needs to be changed somehow, but I'm not sure to what. Can you shed any light on this @jtobin ? (I'm guessing you're the person to ask based on commits on the wallet generator repo)

jtobin commented 3 years ago

Wallet generator is an app mostly authored by @g-a-v-i-n and I that was used awhile ago for generating UP8 wallets, especially around address collection during the move to Azimuth. IIRC its functionality was at one point pulled into Bridge (by cjohnson, I think?), but was then removed again. I think I understood (perhaps a little more strongly than was warranted) that equivalent functionality had been made available in Bridge, and wallet generator was not being used/maintained anyway, so I deprecated the repo, pointing people to Bridge or urbit-key-generation instead.

I've since seen people suggest to others to use wallet generator though, so clearly it must still do something that Bridge doesn't (it calls PaperRenderer, probably?). To your point, it certainly still works, so I'd have no qualms about linking people to it.

(@Fang- do you know any deets about what, if anything, wallet generator did that current-gen Bridge doesn't?)

In any case, my guess is that the relevant docs must have been written before wallet generator was released or used. As far as I know there are no plans to build another app.

Fang- commented 3 years ago

@Fang- do you know any deets about what, if anything, wallet generator did that current-gen Bridge doesn't?

It lets you generate a new wallet for any given @p. In Bridge, you need to log in as the @p, then enter the "reticket" flow, which will also generate a bunch of transactions for moving your asset to the new wallet.

sigilante commented 1 year ago

What's the status of this discussion?

AFAICT https://developers.urbit.org/reference/glossary/hdwallet no longer has any reference to this.

If this is obsolesced by the docs, please let me know or mark closed.