Enabled Desktop Notifications

[marisarow]

Describe the bug After enabling desktop notifications, I have not received any desktop notifications despite being invited to new groups, new dms, new @p mentions, etc.

To Reproduce Steps to reproduce the behavior:

1. Go to Landscape Settings > Notifications
2. Click on 'enable desktop notifications'
3. There are no notifications

Expected behavior I expect desktop notifications.

Additionally, it seems that after enabling desktop notifications there is no clear UI indicating desktop notifications after the initial user interaction which is confusing. The setting seems to have disappeared.

Despite my settings for notifications for group activity not saving (per other bug), I would still would expect desktop notifications for DMs.

Desktop (please complete the following information):

• OS: Mac
• Browser: Chrome
• Version: Version 91.0.4472.114 (Official Build) (x86_64)

Additional context Re: conversation with Edouard: "there may be a few issues at hand namely, you may not have yet opted in to notifications for channels you're subscribed to, and if you have, if you're in the browser tab that landscape is located within, I am under the impression notifications don't show i'll need to test that one out though re: channel notifications in particular, you can check if these are on by visiting the notifications section in system preferences, or by clicking into a channel's settings — DMs should natively push notifications by default"

[matildepark]

Try clicking the hamburger menu in a DM (group or not) and see if it's muted.

If you are looking at the Landscape screen actively, you will not see a notification. If you are idling in the chat (even if tabbed out), you will not see a notification.

[marisarow]

@matildepark thank you for clarifying. in my DMs I do not have a hamburger menu. in groups, I do and all of the groups seem to be automatically muted (fine). however, if I change notifications in system preferences > notifications, I would expect my notification settings to update in the groups. currently, it seems as if the group specific setting overrides the system preference notifications which might be why my toggles aren't saving either (see other issue).

[matildepark]

That would be an issue with optimistic state handling in the settings menu, I'll be assigning that tonight.

[liam-fitzgerald]

Are you accessing landscape through a HTTPS connection? i.e. does the url bar display a lock?

[marisarow]

@liam-fitzgerald yes - https

[liam-fitzgerald]

And you have landscape open in a tab somewhere? The current MVP of web notifications requires that the tab be open in the background somewhere.

[marisarow]

This is not the behavior I would expect. In an era where people have multiple windows it could be open in a window and still not be front and center. Also, I could be looking at another group while getting a DM from someone else on Landscape. I would want a desktop notification for that.

I'm also testing it, but I don't believe I'm getting notifications even if it is a tab in the background.

[marisarow]

Just tested. Received 3 DMS with 0 notifications despite Landscape being open on a tab running in the background.

[matildepark]

In an era where people have multiple windows it could be open in a window and still not be front and center.

If the window is unfocused, it would deliver the notification. (I also believe it would notify you about things happening in other groups.)

I think there is something specific about your browser / OS environment prohibiting a desktop notification, as no one else has ever had an issue like this. (I had such a situation, once, but it was because I disabled notifications for my browser at the OS level a long time ago.) In such a case I would recommend you pair with Liam in a brief call or something to investigate a little.

[liam-fitzgerald]

Happy to pair on this anytime, just put something in my calendar

[matildepark]

@jalehman also can replicate this, on Chrome

[github-actions[bot]]

Stale issue message

[jalehman]

The issue here was OS accessibility issues. This isn't an open issue, but it is a good candidate for usage documentation @marisarow .

[jamesacklin]

Relates to #1282