urbit / landscape

Product board for Landscape.
20 stars 6 forks source link

%graph-store sends `%add-graph` update on `updates` path before there are nodes #1471

Closed rabsef-bicrym closed 2 years ago

rabsef-bicrym commented 2 years ago

Problem When a user joins a graph, agents watching /updates on graph-store get an add-graph before there are necessarily any nodes (i.e. the backlog of the chat) in the graph. Since add-graph always has a blank graph when sent on /updates, and since add-graph with the 'backlog' of the chat prior to the user joining is not in update-log, there's no good timing solution (other than a thread checking recurrently, maybe?)

Proposed Solution send an update on /updates when the initial 'backlog' is received by graph-store for a new graph.

Possible Alternatives put the initial backlog in update-log scry

rabsef-bicrym commented 2 years ago

Actually I think I'm wrong - I was using bad info.