search

urbit / landscape

Product board for Landscape.
20 stars 6 forks source link

lib push-hook: og app can't always be distinguished #292

Open Fang- opened 3 years ago

Fang- commented 3 years ago

Just got this error trace. It's somewhat unexpected, but that's not the point of this issue.

poke failed from %contact-view on wire /join-group/ship/~sabbus/new-computer-working-group
poke-ack
/lib/push-hook/hoon:<[296 5].[300 84]>
/lib/push-hook/hoon:<[295 5].[300 84]>
/lib/push-hook/hoon:<[226 11].[226 32]>
/lib/push-hook/hoon:<[225 9].[227 21]>
/lib/push-hook/hoon:<[222 9].[227 21]>
/lib/push-hook/hoon:<[221 7].[231 19]>
/lib/push-hook/hoon:<[215 7].[231 19]>
/lib/push-hook/hoon:<[214 7].[231 19]>
/sys/vane/gall/hoon:<[1.361 9].[1.361 37]>

That points here:

https://github.com/urbit/urbit/blob/f37bf826848625450819e6ab0848bab1a07c1404/pkg/arvo/lib/push-hook.hoon#L293-L296

But (outside of looking at what things contact-view sends pokes to) there's no way for me to tell what og application was actually running here. Might be nice to include a ~| dap.bowl or similar before the assertions in this library.

jamesacklin commented 2 years ago

@liam-fitzgerald Can you confirm priority here?