search

urbit / shrub

An operating function (Prototype)
https://urbit.org
MIT License
25 stars 0 forks source link

accel: rewrite to lift vase & codegen #40

Closed liam-fitzgerald closed 1 month ago

liam-fitzgerald commented 1 month ago

wat think @hanfel-dovned

tiller-tolbus commented 1 month ago

Excellent and instructive implementation, great job @liam-fitzgerald. Big fan of using raw types instead of a $% with diff messages for the pokes in accel-conf, it makes for a more polymorphic interface and should definitely be used in our other example codebases. cc @hanfel-dovned

Main thing missing is a way to send the output of a cell's computation to another cell for the "spatial command line" story. We could try to just do this through the UI alone, but it would be nice if the provenance of the poke was clear to the receiving end. Now that I'm getting deeper into this, I am not sure if there is a good way to give the user feedback on the result of their poke attempt. But we do need an example of this use-case, even if it's not perfect.

Other nice-to-haves would be full CRUD functionality on cells and dependencies, ie the ability to delete rows and columns, and remove dependencies from a cell.

hanfel-dovned commented 1 month ago

This rules. Internal shrub plexus...

I think the only concept I don't understand is this line. What's a %ford-riff, where/why are we making it, and how is it allowed to accept a vase as the head of its pail? It ends up running the cell code, which propagates back up to accel as a gift, I just don't get the mechanics around what we're making.