urbit / shrub

An operating function (Prototype)
https://urbit.org
MIT License
25 stars 0 forks source link

messenger: test various cases #75

Open tiller-tolbus opened 2 weeks ago

tiller-tolbus commented 2 weeks ago

We haven't tested messenger at all on the live network and in very few kinds of cases on fakeships.

Try using messenger in various intermediate states on the live network and on fakeships, including cases where neo is installed on one ship and not another. See if messenger can catch up when neo is installed after a message is already pending. Document results inside this issue and we will update the issue to handle whatever bugs are found.

We are sure based on some user feedback that messenger has some bugs, so we just need to figure out the extent of them, diagnose, and fix them.

bonbud-macryg commented 2 weeks ago

Can't create a DM chat between two fakeships.

Dojo output on sender ~fun:

>>> %new-dm
>>  %messenger-diff
neo: bad deal: /~fun/home/messenger/dms/~bud
poke-ack
gall: raw-poke fail :neo %neo-raw-poke

Dojo output on receiver ~bud:

clay: read-at-tako fail [desk=%neo care=%b case=[%da p=~2024.6.28..12.05.46..9b5a] path=/neo-raw-poke]
clay: no files match /mar/neo-raw-poke/hoon
[%error-building-mark %neo-raw-poke]
[%error-building-dais %neo-raw-poke]
hanfel-dovned commented 2 weeks ago

I found ~winter-paches's talk on the importance of unit testing to be very convincing.

tiller-tolbus commented 2 weeks ago

Per @liam-fitzgerald this seems like a core problem with Shrubbery networking that needs to be addressed, would assume that cross-network actions will generally fail until this is fixed. Putting this issue on waiting until it's resolved

tiller-tolbus commented 1 week ago

New release fixes shrub networking, please retry @bonbud-macryg

bonbud-macryg commented 6 days ago

Works between fake galaxies, comets, and live planets.

When I create a DM with a ship that isn't a peer yet I get this in the Dojo.

>>> %new-dm
>>  %messenger-diff
; ~mex is your neighbor
[%missing-deli [i=[%p ~mex] t=[i=%home t=~[%messenger %dms [%p ~tex] %pub]]]]
[%lost-moor ship=~mex pith=[i=%home t=[i=%messenger t=~[%dms [%p ~tex] %pub]]]]
[%nothing [i=[%p ~mex] t=[i=%home t=[i=%messenger t=[i=%dms t=[i=[%p ~tex] t=[i=%pub ~]]]]]]]
[ %nothing
  [ i=[%p ~mex]
      t
    [ i=%home
      t=[i=%messenger t=[i=%dms t=[i=[%p ~tex] t=[i=%pub t=[i=[%da ~2024.7.11..13.54.52] ~]]]]]
    ]
  ]
]
[%fresh [i=[%p ~mex] t=[i=%home t=[i=%messenger t=[i=%dms t=[i=[%p ~tex] t=[i=%pub ~]]]]]]]
[ %missing-deli
  [i=[%p ~mex] t=[i=%home t=~[%messenger %dms [%p ~tex] %pub [%da ~2024.7.11..13.54.52]]]]
]

When I create a new DM with a ship I am peers with I get this in the Dojo.

>>> %new-dm
>>  %messenger-diff
>>  %dm-diff
>>> 'got dm diff'
liam-fitzgerald commented 6 days ago

Ugh this is an upstream issue I think ffs, will investigate later today.

On Thu, Jul 11, 2024 at 9:03 AM, bonbud-macryg @.***> wrote:

Works between fake galaxies, comets, and live planets.

When I create a DM with a ship that isn't a peer yet I get this in the Dojo.

%new-dm %messenger-diff ; ~mex is your neighbor [%missing-deli [i=[%p ~mex] t=[i=%home t=~[%messenger %dms [%p ~tex] %pub]]]] [%lost-moor ship=~mex pith=[i=%home t=[i=%messenger t=~[%dms [%p ~tex] %pub]]]] [%nothing [i=[%p ~mex] t=[i=%home t=[i=%messenger t=[i=%dms t=[i=[%p ~tex] t=[i=%pub ~]]]]]]] [ %nothing [ i=[%p ~mex] t [ i=%home t=[i=%messenger t=[i=%dms t=[i=[%p ~tex] t=[i=%pub t=[i=[%da ~2024.7.11..13.54.52] ~]]]]] ] ] ] [%fresh [i=[%p ~mex] t=[i=%home t=[i=%messenger t=[i=%dms t=[i=[%p ~tex] t=[i=%pub ~]]]]]]] [ %missing-deli [i=[%p ~mex] t=[i=%home t=~[%messenger %dms [%p ~tex] %pub [%da ~2024.7.11..13.54.52]]]] ]

When I create a new DM with a ship I am peers with I get this in the Dojo.

%new-dm %messenger-diff %dm-diff 'got dm diff'

— Reply to this email directly, view it on GitHub https://github.com/urbit/shrub/issues/75#issuecomment-2222886858, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALFCFFVKZTKZ675MU7EUL4TZLZ7CZAVCNFSM6AAAAABKAKRBPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRSHA4DMOBVHA . You are receiving this because you were mentioned.Message ID: @.***>