urbit / shrub

An operating function (Prototype)
https://urbit.org
MIT License
29 stars 2 forks source link

neo: cull a node should automatically cull all kids #98

Closed YunPearce closed 1 month ago

YunPearce commented 1 month ago

When we send %cull card to shrub ideal behaviour would be not to pre check if shrub has kids and manually send cards to all kids under that shrub but rather have it taken care of by just sending single %tomb card that will tombstone all kids underneath it and itself. Currently when sending list of %tomb %cull cards where first cards are tombstoning kids and last one tomb parent, it often crashes, on parent shrub. Seems like it still has information about kids stuck in loam:dirt.

YunPearce commented 1 month ago

%cull already has recursive behaviour. Just had a bug were case of child shrub wouldn't get pulled correctly. Fixed in 6846682 commit