search

urbit / talk

Urbit notifications and chat module
10 stars 7 forks source link

Webtalk on moons #49

Open Fang- opened 6 years ago

Fang- commented 6 years ago

When loading webtalk off a moon, it tries to load from the moon's Hall. Since moons use their planet's Hall, there's nothing there, so no messages ever load. It should be sending subscriptions to the planet instead.

xykj61 commented 6 years ago

It'd be sweet if this got fixed.

Fang- commented 6 years ago

So apparently you can't just be lazy about it and window.urb.ship = planet if ship is moon at the top of the js and have that work. Like, it loads the messages, but sending seems broken.

Unassigned myself because eth work, but I could take a stab at this over the weekend maybe. Really it's probably just changing the urb.bind parameters to target the planet, but I'll have to dive deeper to remember how that worked exactly.

Fang- commented 6 years ago

Also I guess cc @c-johnson to take this into account for Collections. Maybe in the future moons will provide actual functional mirrors of their planet's hall (they probably should) but for now you want to take care here not to talk to moons when doing hall stuff.