search

urbit / tree

The web interface for your urbit.
13 stars 7 forks source link

Compiled css/js is not reflected in served desk #12

Closed knubie closed 8 years ago

knubie commented 8 years ago

I cloned this repo to make some changes to the css. Specifically I made the background of the nav red (as a test). I compiled the source into main.js and main.css and deployed them to my %sandbox desk locally as described here: https://github.com/urbit/tree#deploy to test my changes.

When navigating around static, the changes are not reflected, as seen here: screen1

However when navigating to tree/main the changes suddenly appear: screen2

I tried emptying cache, and 3 different browsers. I also tried serving and deploying to %home and witnessed the same results.

May be related to arvo#154.

galenwp commented 8 years ago

I updated those deploy instructions with the ?dbg.nopack query string info just a bit ago.

Does http://localhost:8080/tree?dbg.nopack=true show your changes?

On Jun 5, 2016, at 3:02 PM, Matthew Steedman notifications@github.com wrote:

I cloned this repo to make some changes to the css. Specifically I made the background of the nav red (as a test). I compiled the source into main.js and main.css and deployed them to my %sandbox desk locally as described here: https://github.com/urbit/tree#deploy to test my changes.

When navigating around static, the changes are not reflected, as seen here:

However when navigating to tree/main the changes suddenly appear:

I also tried serving and deploying to %home and witnessed the same results.

May be related to arvo#154.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

knubie commented 8 years ago

Indeed it does, thanks!

galenwp commented 8 years ago

Great! Sorry for the confusion. Does that make sense? We concatenate them for production to keep the number of requests down.

On Jun 5, 2016, at 4:28 PM, Matthew Steedman notifications@github.com wrote:

Closed #12.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

ohAitch commented 8 years ago

I really should figure out the pack renderers, it seems like the manual solution is turning out too error-prone/confusing.

On Sunday, 5 June 2016, Galen Wolfe-Pauly notifications@github.com wrote:

Great! Sorry for the confusion. Does that make sense? We concatenate them for production to keep the number of requests down.

On Jun 5, 2016, at 4:28 PM, Matthew Steedman <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

Closed #12.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/urbit/tree/issues/12#issuecomment-223844713, or mute the thread https://github.com/notifications/unsubscribe/ABxXhlwB3rVuqg4-BDXvRgAvPNcH6iw6ks5qI1yigaJpZM4IudXz .

galenwp commented 8 years ago

It's a little confusing — but there wasn't an explanation in the readme until like ~2h ago.

knubie commented 8 years ago

@galenwp Yeah, so ~.codemirror_fonts_bootstrap_main.css and ~.main_urb.js are the files actually being requested (which are just main.css and main.js concatenated with other dependencies), and not the main.css and main.js that were generated with build/watch.sh.

Makes sense to me.

galenwp commented 8 years ago

Yep. That's it. We'll see if others get tripped up.

Look forward to the CSS fixes you come up with. There are definitely rough spots in this thing.