search

urbit / tree

The web interface for your urbit.
13 stars 7 forks source link

Mobile fixes #20

Closed knubie closed 8 years ago

knubie commented 8 years ago

Some various fixes for the tree nav on mobile. I can provide some screenshots / videos of the bugs tomorrow.

galenwp commented 8 years ago

Awesome. Can look closely tomorrow.

On Jun 28, 2016, at 9:22 PM, Matthew Steedman notifications@github.com wrote:

Some various fixes for the tree nav on mobile. I can provide some screenshots / videos of the bugs tomorrow.

You can view, comment on, or merge this pull request online at:

https://github.com/urbit/tree/pull/20

Commit Summary

Fix nav width on xs Use TreeActions to control nav state on scroll Fix disappearing nav on mobile safari Fix auto-hiding nav in mobile safari File Changes

M css/_nav.scss (4) M js/utils/scroll.coffee (38) Patch Links:

https://github.com/urbit/tree/pull/20.patch https://github.com/urbit/tree/pull/20.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

knubie commented 8 years ago

Fix nav width on xs – 7fd3884

The width was at 100% when fixed, but ignored the margins of the container.

Before

screen shot 2016-06-28 at 8 45 02 pm

After

screen shot 2016-06-28 at 8 46 29 pm

Use TreeActions to control nav state on scroll 7d59915

Wasn't able to get a video of this one but if you select the hamburger to drop down the menu, then scroll down to collapse it, then click the hamburger again, nothing happens. You have to tap it a second time to trigger the open state.

Fix disappearing nav on mobile safari – c903a9e

This just looks like some render bug on mobile safari.

Reproduction video

Fix auto-hiding nav in mobile safari – 871fcfe

This might be a bit hard to see in the video, but if you scroll up until the nav is fixed and then let the browser continue to scroll with inertia, it will trigger the toolbar to expand, causing a scroll event that looks like scrolling up which will cause the nav to become position: absolute again. (It's hard to see because the nav also disappears and reappears due to the previous bug.

Reproduction video

galenwp commented 8 years ago

Okay "tomorrow" was actually a few more days. This is so awesome! These things have been bugging me for a while. Great attention to detail.