urbit / tree

The web interface for your urbit.
13 stars 7 forks source link

Comments reverse order #26

Closed galenwp closed 7 years ago

galenwp commented 8 years ago

There should be an option like comments-order that can flip the order of comments and put the comment box at the bottom.

ohAitch commented 8 years ago

I'd just go for "comments: reverse", I'm kind of wary of growing a half-dozen yaml fields that boil down to "type: forum-post".

On Thursday, 28 July 2016, Galen Wolfe-Pauly <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

There should be an option like comments-order that can flip the order of comments and put the comment box at the bottom.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/urbit/tree/issues/26, or mute the thread https://github.com/notifications/unsubscribe-auth/ABxXhrABhm34Zn9GbnRaMhE7f_6Pzwpzks5qaOP6gaJpZM4JXcJ8 .

galenwp commented 8 years ago

Works for me, although I wish there were clear inverses. Does comments:forward mean the same thing as comments:true?

ohAitch commented 8 years ago

I'd do something like "show", "show reverse" eventually, if we e.g. add an "only postable by logged-in urbits" option.

On Friday, 29 July 2016, Galen Wolfe-Pauly notifications@github.com wrote:

Works for me, although I wish there were clear inverses. Does comments:forward mean the same thing as comments:true?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/urbit/tree/issues/26#issuecomment-236250876, or mute the thread https://github.com/notifications/unsubscribe-auth/ABxXhiZC8FkEnFV9YXa00gyWsF1bOBk7ks5qakA3gaJpZM4JXcJ8 .

galenwp commented 8 years ago

Well there's never going to be a 'hide', right? That is, the existence of the comments attribute implies that we want to show comments — and the body tells us what to do with them?

ohAitch commented 8 years ago

I'm mentally slotting in "hide" for the unnamed default, whose value rn is effectively "". But sure it could be e.g. "full", contrast "read". My point is that three options is probably too early to make it rigorous.

(For now, I'm just going to pretend "true" stands for "in true order", as opposed to "reverse" which is chrono order)

On Friday, 29 July 2016, Galen Wolfe-Pauly notifications@github.com wrote:

Well there's never going to be a 'hide', right? That is, the existence of the comments attribute implies that we want to show comments — and the body tells us what to do with them?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/urbit/tree/issues/26#issuecomment-236264172, or mute the thread https://github.com/notifications/unsubscribe-auth/ABxXhkDAlqACawpjqw2McO5vqfvNaDShks5qakw0gaJpZM4JXcJ8 .