search

urbit / tree

The web interface for your urbit.
13 stars 7 forks source link

Clicking a link to a page in /pages shows the source view instead of the page #7

Open zaphar opened 8 years ago

zaphar commented 8 years ago

If you start here: https://hidduc-posmeg.urbit.org/pages/hidducs-notes/tutorial and click the hoon tutorials link you will go to a source view of the hoon file instead of the page. This is likely due to the fact that tree interecepts link clicks and modifies the url while still loading them in tree.

This is either working as intended or broken depending on how you look at it. But it seems likely that you will want to be able to navigate to actual /pages links from tree at some point and it looks like there is no facility for that at the moment.

galenwp commented 8 years ago

I think hidduc may be down at the moment, but what’s the exact content of the href attribute, and what is the URL that it navigates to?

Things hosted under /pages shouldn’t use the tree machinery at all, unless you’re including it by hand. At least, I think that’s right.

On Mar 30, 2016, at 4:26 PM, Jeremy Wall notifications@github.com wrote:

If you start here: https://hidduc-posmeg.urbit.org/pages/hidducs-notes/tutorial https://hidduc-posmeg.urbit.org/pages/hidducs-notes/tutorial and click the hoon tutorials link you will go to a source view of the hoon file instead of the page. This is likely due to the fact that tree interecepts link clicks and modifies the url while still loading them in tree.

This is either working as intended or broken depending on how you look at it. But it seems likely that you will want to be able to navigate to actual /pages links from tree at some point and it looks like there is no facility for that at the moment.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/urbit/tree/issues/7

ohAitch commented 8 years ago

It shouldn't use tree machinery, but tree doesn't know it shouldn't use tree machinery, so you can navigate to them from tree and the machinery will get inadvertently applied.

On Thursday, 31 March 2016, Galen Wolfe-Pauly notifications@github.com wrote:

I think hidduc may be down at the moment, but what’s the exact content of the href attribute, and what is the URL that it navigates to?

Things hosted under /pages shouldn’t use the tree machinery at all, unless you’re including it by hand. At least, I think that’s right.

On Mar 30, 2016, at 4:26 PM, Jeremy Wall <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

If you start here: https://hidduc-posmeg.urbit.org/pages/hidducs-notes/tutorial < https://hidduc-posmeg.urbit.org/pages/hidducs-notes/tutorial> and click the hoon tutorials link you will go to a source view of the hoon file instead of the page. This is likely due to the fact that tree interecepts link clicks and modifies the url while still loading them in tree.

This is either working as intended or broken depending on how you look at it. But it seems likely that you will want to be able to navigate to actual /pages links from tree at some point and it looks like there is no facility for that at the moment.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub < https://github.com/urbit/tree/issues/7>

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/urbit/tree/issues/7#issuecomment-204092679

galenwp commented 8 years ago

Oh, ok. I think maybe the example is backwards?

That is, J says start with /pages/hidducs-notes/tutorial and click the hoon tutorials? So: start on something in /pages then go into tree. But you’re saying it’s coming to /pages from tree doesn’t work?

On Mar 31, 2016, at 12:52 PM, Anton Dyudin notifications@github.com wrote:

It shouldn't use tree machinery, but tree doesn't know it shouldn't use tree machinery, so you can navigate to them from tree and the machinery will get inadvertently applied.

On Thursday, 31 March 2016, Galen Wolfe-Pauly notifications@github.com wrote:

I think hidduc may be down at the moment, but what’s the exact content of the href attribute, and what is the URL that it navigates to?

Things hosted under /pages shouldn’t use the tree machinery at all, unless you’re including it by hand. At least, I think that’s right.

On Mar 30, 2016, at 4:26 PM, Jeremy Wall <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

If you start here: https://hidduc-posmeg.urbit.org/pages/hidducs-notes/tutorial < https://hidduc-posmeg.urbit.org/pages/hidducs-notes/tutorial> and click the hoon tutorials link you will go to a source view of the hoon file instead of the page. This is likely due to the fact that tree interecepts link clicks and modifies the url while still loading them in tree.

This is either working as intended or broken depending on how you look at it. But it seems likely that you will want to be able to navigate to actual /pages links from tree at some point and it looks like there is no facility for that at the moment.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub < https://github.com/urbit/tree/issues/7>

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/urbit/tree/issues/7#issuecomment-204092679

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/urbit/tree/issues/7#issuecomment-204099650

zaphar commented 8 years ago

Right if you start in tree and then click on a link to pages it will fail. And yes hidduc is down churning through a bunch of ames requests and spewing stacktraces :-p

On Thu, Mar 31, 2016 at 3:20 PM, Galen Wolfe-Pauly <notifications@github.com

wrote:

Oh, ok. I think maybe the example is backwards?

That is, J says start with /pages/hidducs-notes/tutorial and click the hoon tutorials? So: start on something in /pages then go into tree. But you’re saying it’s coming to /pages from tree doesn’t work?

On Mar 31, 2016, at 12:52 PM, Anton Dyudin notifications@github.com wrote:

It shouldn't use tree machinery, but tree doesn't know it shouldn't use tree machinery, so you can navigate to them from tree and the machinery will get inadvertently applied.

On Thursday, 31 March 2016, Galen Wolfe-Pauly notifications@github.com wrote:

I think hidduc may be down at the moment, but what’s the exact content of the href attribute, and what is the URL that it navigates to?

Things hosted under /pages shouldn’t use the tree machinery at all, unless you’re including it by hand. At least, I think that’s right.

On Mar 30, 2016, at 4:26 PM, Jeremy Wall <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

If you start here: https://hidduc-posmeg.urbit.org/pages/hidducs-notes/tutorial < https://hidduc-posmeg.urbit.org/pages/hidducs-notes/tutorial> and click the hoon tutorials link you will go to a source view of the hoon file instead of the page. This is likely due to the fact that tree interecepts link clicks and modifies the url while still loading them in tree.

This is either working as intended or broken depending on how you look at it. But it seems likely that you will want to be able to navigate to actual /pages links from tree at some point and it looks like there is no facility for that at the moment.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub < https://github.com/urbit/tree/issues/7>

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/urbit/tree/issues/7#issuecomment-204092679

— You are receiving this because you commented. Reply to this email directly or view it on GitHub < https://github.com/urbit/tree/issues/7#issuecomment-204099650>

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/urbit/tree/issues/7#issuecomment-204108020

Jeremy Wall http://jeremy.marzhillstudios.com Jeremy@marzhillstudios.com