search

urbit / urbit-key-generation

Key derivation and HD wallet generation functions for Urbit
MIT License
15 stars 8 forks source link

generateCode output seems off #103

Closed jtobin closed 2 years ago

jtobin commented 2 years ago

Have received reports of unexpected results from generateCode and am observing some myself, so I think a bug may have slipped into this implementation despite testing. Looking into it.

jtobin commented 2 years ago

Ok, so after some examination it looks like this implementation should be fine.

I think results can be counterintuitive for booted ships that are not managed via UP8 wallets (since the code will not be immediately derivable, the networking keys having been derived from an authentication token in Bridge) , or if the life (or potentially step) are not set appropriately. I'll touch up the docs to try and resolve this.

jtobin commented 2 years ago

A doc blurb about this has been added to the readme in b2bc8cafc.