urbit / urbit-key-generation

Key derivation and HD wallet generation functions for Urbit
MIT License
15 stars 8 forks source link

Voting seeds should not be generated for planets and stars #16

Closed g-a-v-i-n closed 5 years ago

g-a-v-i-n commented 5 years ago

Currently planets and stars have voting seeds generated for them despite not having this capability.

FYI delegate seeds are now called votings seeds per https://github.com/urbit/keygen-js/issues/14

jtobin commented 5 years ago

I.e. for planet and star wallets? There are no per-ship voting seeds implemented here at present, unless I've misunderstood something.

From the changes in urbit/constitution#23, I think the implementation here might actually have to be changed anyway, though. I'll take a look in more detail.

g-a-v-i-n commented 5 years ago

Delegate seeds are also being changed so that they're generated per ship.