search

urbit / urbit-key-generation

Key derivation and HD wallet generation functions for Urbit
MIT License
15 stars 8 forks source link

Audit improvements #21

Closed Fang- closed 5 years ago

Fang- commented 5 years ago

Granular and standalone commits for your reviewing pleasure.

As per @iamwillkim's request:

  1. Extraneous functions: These points make sense and we should do this (we don’t need to break out short one-liners)
  2. Documentation issues: all points valid, address all
  3. Test coverage: Jared added a few more tests, so we have better coverage, but we need two more tests to hit 100% branch coverage (one for childSeedFromSeed() and one for get()).

This also makes management nodes per-ship rather than one per wallet/owner. That affects networking seeds, I'm not sure if I did the best possible job of capturing management seeds for use there. Please review with a strict eye on functional style.

Fang- commented 5 years ago

There may be argon2-wasm interface changes incoming here: urbit/argon2-wasm#3. I will update this PR once those land.