search

urbit / urbit-key-generation

Key derivation and HD wallet generation functions for Urbit
MIT License
15 stars 8 forks source link

Add more documentation and tests #23

Closed iamwillkim closed 5 years ago

iamwillkim commented 5 years ago

A few more documentation changes to align param types and a few more tests

jtobin commented 5 years ago

:+1: :+1:

I think there are a couple of places where the return type should still be a Promise, and I just happened to notice a slightly muddled doc on one of my own helper functions while reviewing. I'll push a fixup commit and then merge.

jtobin commented 5 years ago

This would have been a good time for me to remember the [ci skip] tag too..