Fix incorrect Ethereum address derivation

urbit / urbit-key-generation

Key derivation and HD wallet generation functions for Urbit

MIT License

15 stars 8 forks source link

Fix incorrect Ethereum address derivation #37

Closed jtobin closed 5 years ago

jtobin commented 5 years ago

Resolves #36.

addressFromSecp256k1Public had previously:

Hashed the compressed public key.
Included the leading parity byte of the key when hashing.

Both will lead to incorrect address derivation. addressFromSecp256k1Private was similarly affected, since it makes use of the public key variant internally.