ownershipNode derived from wrong source (?)

urbit / urbit-key-generation

Key derivation and HD wallet generation functions for Urbit

MIT License

15 stars 8 forks source link

ownershipNode derived from wrong source (?) #5

Closed g-a-v-i-n closed 5 years ago

g-a-v-i-n commented 5 years ago

According to previous implementation and design: derive a wallet from the ownerSeed directly

Fang- commented 5 years ago

Github is not showing a comment from you which I did receive an email for, so just in case you didn't intentionally delete that and want an answer:

The "before" case doesn't include metadata because there really is no metadata to speak of here. The ownership seed wasn't derived using a salt, so everything would be null. Both the "null meta" and "no meta" cases are inconsistent with other seeds, but afaic that's fine.

g-a-v-i-n commented 5 years ago

I realized that whole post was wrong, and I resolved the issue locally. childNodeFromSeed() uses childSeedFromSeed() which is not how the ownership node was initially derived,.

g-a-v-i-n commented 5 years ago

Resolved in #7