Update to match UP 8 spec

urbit / urbit-key-generation

Key derivation and HD wallet generation functions for Urbit

MIT License

15 stars 8 forks source link

Update to match UP 8 spec #52

Closed jtobin closed 5 years ago

jtobin commented 5 years ago

Now matches UP 8. I also took the opportunity to do some general housecleaning while updating everything -- gutted lodash, got rid of redundant helper functions, fixed up docs/formatting, improved helper function names, etc.

jtobin commented 5 years ago

@Fang- If you can eyeball the wallets in test/assets and confirm they match the keygen-hoon stuff, I'll consider this good to merge, and will push a release to npm.

jtobin commented 5 years ago

(Going to merge this just to ensure that an updated version is available on npm.)

Fang- commented 5 years ago

For the record, I settled with @jtobin that his tests were correct and my tests were wrong. Keygen-js confirmed for Being Good, keygen-hoon confirmed for Good Soon.