modify meta field, fix browserify

urbit / urbit-key-generation

Key derivation and HD wallet generation functions for Urbit

MIT License

15 stars 8 forks source link

modify meta field, fix browserify #78

Closed g-a-v-i-n closed 4 years ago

g-a-v-i-n commented 4 years ago

split meta.generator into two fields, generatorName and generatorVersion
update tests
Fix Browserify by using the old package.json syntax, resolves #77

g-a-v-i-n commented 4 years ago

The usecase is that I want to print the version of the generator on the paper wallets, but I don't want to have to do any string processing to the existing value urbit-key-generation-v1.x.y to separate the version number from the lib name.

Fang- commented 4 years ago

But the lib name is part of the version number? Like, it matters if it's urbit-key-generation version 1, or urbit-key-generation-hoon version 1.

(I don't actually feel super strongly though, I won't stop you.)

g-a-v-i-n commented 4 years ago

Sounds great

g-a-v-i-n commented 4 years ago

muchos gracias

jtobin commented 4 years ago

On Thu, Aug 29, 2019 at 12:03:17PM -0700, g-a-v-i-n wrote:

muchos gracias

de nada, señor