search

urbit / urbit-key-generation

Key derivation and HD wallet generation functions for Urbit
MIT License
15 stars 8 forks source link

Add shard function. #9

Closed jtobin closed 5 years ago

jtobin commented 5 years ago

Resolves #8.

shard mutates the existing wallet, which seems undesirable to me, but which also seems to be common practice in JS-land -- actually producing a copy of an object is surprisingly difficult.

joemfb commented 5 years ago

@jtobin, I'm inclined to .gitignore the entire coverage directory. Is there any reason that it needs to be checked-in?

jtobin commented 5 years ago

@joemfb Also inclined to remove it. It was already in there, so I didn't know if it was being used for anything.

@gavinpatkinson Should we gut that?

g-a-v-i-n commented 5 years ago

Yeah, lets remove it.

g-a-v-i-n commented 5 years ago

I'm going to merge this into the shard branch instead of master.