urbit / urbit-key-generation

Key derivation and HD wallet generation functions for Urbit
MIT License
15 stars 8 forks source link

Add bitcoin testnet support #97

Closed pkova closed 3 years ago

pkova commented 3 years ago

Working on various parts of the bitcoin wallet two problems came up with my stuff from #92.

1) We need bitcoin testnet support. 2) The default output key format required unnecessary, duplicated and error prone massaging in both Bridge and our BTC Wallet. It's better to do it here, so instead of outputting keys: {public, private, chain, address} we now output keys:{xpub, xprv}.

This PR addresses both problems.

pkova commented 3 years ago

Yo @jtobin, release this to npm when you got the time.

jtobin commented 3 years ago

Done!

Fang- commented 3 years ago

@pkova looks like updating Bridge to work with this isn't entirely trivial a task (key transformation shenanigans involved). Humbly requesting that you do a matching Bridge PR when you have the time. Thank you! (: