search

urbit / urbit.org

The source for urbit.org
https://urbit.org
MIT License
93 stars 197 forks source link

=> ligature in rune reference #1006

Closed ohAitch closed 3 years ago

ohAitch commented 4 years ago

Looks like something fancy about the header font: urbit org_docs_reference_hoon-expressions_rune_tis_ Screenshot 2020-05-10 18 04 04

jfranklin9000 commented 4 years ago

It's back. Again. https://github.com/urbit/docs/issues/611

matildepark commented 4 years ago

In Brave:

image

It looks like Firefox and Chromium browsers respect font-feature-settings but Safari doesn't, here. What browser are you using?

matildepark commented 4 years ago

(Honestly I think we should be using monospace fonts for these runes anyway. @syzygyzer Thoughts? Would you guys be willing to wrap the runes in code backticks?)

drbeefsupreme commented 4 years ago

I had commented before I made the PR but my internet went out so I guess it was swallowed. Yeah that's how it should have been all along @matildepark so I went ahead and did it.

jfranklin9000 commented 4 years ago

None of the browsers work for me.

macOS 10.14.6

Firefox 75.0

tisgar-firefox

Chrome 81.0.4044.138

tisgar-chrome

Safari 12.1.2

tisgar-safari
matildepark commented 4 years ago

Oh, I think I know what's going on here — same as https://github.com/urbit/urbit.org/pull/404

I'll look into this

ohAitch commented 4 years ago

MDN recommends against font-feature-settings:

Note: Whenever possible, Web authors should instead use the font-variant shorthand property or an associated longhand property such as font-variant-ligatures,

matildepark commented 4 years ago

Oh wait why should I look into this — urbit/docs#876 fixes this issue