urbit / urbit.org

The source for urbit.org
https://urbit.org
MIT License
93 stars 197 forks source link

tisgar renders strangely in rune doc #934

Closed jfranklin9000 closed 3 years ago

jfranklin9000 commented 5 years ago

but the DOM looks ok:

https://urbit.org/docs/reference/hoon-expressions/rune/tis/

tisgar-before

The solution is to inline code it:

### `=>` "tisgar"
tisgar-after

(It probably should have been inlined in the first place.)

I don't have time to submit a PR but if someone wants to pick this up be sure to convert all the runes.

jfranklin9000 commented 5 years ago

I don't think the quotes around the rune names ( "tisgar" ) look good. I would delete them.

Also, there should be a horizontal rule between the rune descriptions.

rmariani commented 5 years ago

I frankly don't like the inline look, it makes it harder for the eye to catch it, since the bolding is gone and code directly below it is also inline code.

@msutherl, any ideas on how to not make => render in such a way?

matildepark commented 5 years ago

I know you can disable these ligatures with some css that states font settings. If that helps.

Sent from my iPhone

On Aug 12, 2019, at 4:23 PM, rmariani notifications@github.com wrote:

I frankly don't like the inline look, it makes it harder for the eye to catch it, since the bolding is gone and code directly below it is also inline code.

@msutherl, any ideas on how to not make => render in such a way?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

matildepark commented 5 years ago

I believe @msutherl hotfixed this, so this issue can be closed, @rmariani ?

jfranklin9000 commented 5 years ago

Was there a PR for the fix?

matildepark commented 5 years ago

Pushed directly to master, I think: https://github.com/urbit/urbit.org/commit/7246d7349057e198df786360121c1d091bb7dd6a

rmariani commented 5 years ago

Thansk @msutherl

jfranklin9000 commented 5 years ago

it's back

matildepark commented 5 years ago

Good catch, refixed in https://github.com/urbit/urbit.org/commit/889d07970997aff937b58e16ac2b06ffdc4a159c

(I think the runes in these headers should be wrapped in backticks anyway, but this fixes it for now.)