search

ureishi / QvPen

VRChat World Pen.
64 stars 12 forks source link

Changed vpmDependencies because UdonSharp is now integrated into the VRChat Worlds SDK. #20

Closed BluWizard10 closed 9 months ago

BluWizard10 commented 11 months ago

Yes, you heard that right. No more separate UdonSharp Package needed anymore. It has been fully moved into the VRChat Worlds SDK as of v3.4.0 and newer.

Because of this, I changed the vpmDependencies to com.vrchat.worlds now. This prevents UdonSharp from being incorrectly reintroduced to the Project when it's not supposed to, causing the project to break. This is a serious bug in older versions of Creator Companion. So I hope most people have actually updated VCC to avoid this bug.

Either way, this is a future-proofing safety measure. I highly recommend you consider merging my commit and bumping QvPen to 3.2.10 as a new release.

As a bonus, I removed the "unity": line as well. This prepares QvPen to fully support Unity 2022 out of the box when the new SDK releases supporting Unity 2022.

anatawa12 commented 9 months ago

I think this will make unnecessarily QvPen incompatible with SDK 3.3.0/older.

In addition, in modern VCC, (thanks to fixing vrchat-community/creator-companion#367) declaring compatible unity to 2019.4 in "unity" field means compatible with 2019.4 or later including 2022.3. In addition, if there are no "unity" field, VCC warns about that when installing to 2022 project. So, I think removing "unity" field is not good

BluWizard10 commented 9 months ago

Yeah, I didn't know that "unity" would play a major role in the latest version of Creator Companion in regards to the upgrade to Unity 2022. I meant to make that change here, but thanks for doing that.