urfave / cli

A simple, fast, and fun package for building command line apps in Go
https://cli.urfave.org
MIT License
21.88k stars 1.69k forks source link

Perfectionist's Checklist #1612

Open abitrolly opened 1 year ago

abitrolly commented 1 year ago

Here are some things that I found internally unsatisfying in v2.

To be expanded..

What problem does this solve?

Reaching inner peace.

dearchap commented 1 year ago

@abitrolly I agree with all of these points. In fact these have been raised before see

https://github.com/urfave/cli/issues?q=is%3Aopen+is%3Aissue+label%3Aarea%2Fv3

However at this point v2 is in maintenance mode so no new features/functionality. Most if not all of your issues are slated to be fixed in v3. Why v3 you say ? We wanted to take the most requested features and create a new version of the software . As part of this we've rewritten the flag code to use generics so that feature addition is localized and more manageable than it is currently. For example see the recent changes for persistent flags in v3. It required an update to just 4 files vs currently we would have to update almost 15-20 files. So code maintenance is better . That being said are you up for these changes coming to v3?

abitrolly commented 1 year ago

I don't understand generics, and I don't know how much time it will be needed for me to get it, but when v3 is ready to be used, I can easily go through this checklist to see if it works for me.

abitrolly commented 1 year ago

@dearchap renamed feature request template to point to v3 https://github.com/urfave/cli/pull/1613

dearchap commented 1 year ago

Thanks @abitrolly