Closed austinvazquez closed 1 year ago
@austinvazquez think you can update flag_bool and flag_float as well to use this ? Thanks
@austinvazquez think you can update flag_bool and flag_float as well to use this ? Thanks
Oh great catch, pushed changes + updated messaging.
@austinvazquez Excellent thank you for the quick turnaround
What type of PR is this?
What this PR does / why we need it:
This change swaps the
ToString
implementation under the hood of flag_[bool|float|int|uint].go to usestrconv
package instead offmt
package.This is a non-functional change to optimize the
ToString
operation for [bool|float|int|uint] flags.Which issue(s) this PR fixes:
None
Testing
Release Notes
No user facing changes.