Move test helpers from docs_test.go to helpers_test.go

urfave / cli

A simple, fast, and fun package for building command line apps in Go

https://cli.urfave.org

MIT License

21.9k stars 1.69k forks source link

Move test helpers from docs_test.go to helpers_test.go #1846

Closed dolmen closed 6 months ago

dolmen commented 6 months ago

What type of PR is this?

cleanup

What this PR does / why we need it:

Refactor unit tests to move test helpers (testApp, expectFileContent) from docs_test.go into the existing helpers_test.go. Those helpers are used by both docs_test.go and fish_test.go.

Why? I will soon propose to add build tags in docs.go to allow to skip the features it provides, and those dependencies get in the way.

Release Notes

NONE

dolmen commented 6 months ago

Wong branch.

dolmen commented 6 months ago

Build tag is already available in #1375.