search

urfave / cli

A simple, fast, and fun package for building command line apps in Go
https://cli.urfave.org
MIT License
21.9k stars 1.69k forks source link

v2: Add build tag urfave_cli_no_suggest #1847

Closed dolmen closed 6 months ago

dolmen commented 6 months ago

What type of PR is this?

What this PR does / why we need it:

Like urfave_cli_no_docs (in docs.go), allow to disable flag and command suggestions at build time (and drop dependency on module github.com/xrash/smetrics) with a new urfave_cli_no_suggest build tag:

$ go build -tags urfave_cli_no_suggest,urfave_cli_no_docs

Release Notes

Add `urfave_cli_no_suggest` build tag to disable suggestions and drop dependency on module [`github.com/xrash/smetrics`](https://pkg.go.dev/github.com/xrash/smetrics) for smaller binaries.
dearchap commented 6 months ago

@dolmen Can you fix the test failures ?

dolmen commented 6 months ago

@dearchap Tests fixed by approving API docs changes.