SliceFlagSeparator can affect subcommands, whereas DisableSliceFlagSeparator does not. - Githubissues

urfave / cli

A simple, fast, and fun package for building command line apps in Go

https://cli.urfave.org

MIT License

21.9k stars 1.69k forks source link

SliceFlagSeparator can affect subcommands, whereas DisableSliceFlagSeparator does not. #1856

Closed chenlein closed 2 months ago

chenlein commented 5 months ago

Checklist

[y] Are you running the latest v3 release? The list of releases is here.
[y] Did you check the manual for your release? The v3 manual is here.
[ ] Did you perform a search about this feature? Here's the GitHub guide about searching.

What problem does this solve?

That can influence subcommands by setting the DisableSliceFlagSeparator parameter in the top-level command.

Solution description

As the behavior of the DisableSliceFlagSeparator parameter shoud be consistent with that of SliceFlagSeparator

Describe alternatives you've considered

set DisableSliceFlagSeparator flag for all subcommands!

dearchap commented 2 months ago

@chenlein this is by design since we are assumimg that the user knows which commands needs the slice flag separator and which doesnt. This is tough to fix without breaking user expectations .