Vendor usage of `github.com/xrash/smetrics` for suggestions

urfave / cli

A simple, fast, and fun package for building command line apps in Go

https://cli.urfave.org

MIT License

21.89k stars 1.69k forks source link

Vendor usage of `github.com/xrash/smetrics` for suggestions #1892

Closed meatballhat closed 1 month ago

meatballhat commented 2 months ago

The usage of smetrics.JaroWinkler should be vendored into this source tree or replaced with an implementation that is within this source tree to support the goal of only requiring the Go standard library.

yigithankarabulut commented 2 months ago

smetrics.JaroWinkler on line 25 in suggestions.go file, do we need to write this function instead of using it? If so, could you assign to me?

meatballhat commented 2 months ago

@yigithankarabulut Thank you! Replacing the function usage with an internal function SGTM. Vendoring the library implementation with attribution is also acceptable. Your call!