Replace Jaro-Winkler algorithm usage with an internal function

urfave / cli

A simple, fast, and fun package for building command line apps in Go

https://cli.urfave.org

MIT License

21.89k stars 1.69k forks source link

Replace Jaro-Winkler algorithm usage with an internal function #1893

Closed yigithankarabulut closed 1 month ago

yigithankarabulut commented 2 months ago

What type of PR is this?

cleanup

What this PR does / why we need it:

To support the goal of only requiring the Go standard library. We were using the Jaro-Winkler algorithm for the suggestion from the "xrash/smetrics" package. This function was rewritten to be faithful to stdlib.

Which issue(s) this PR fixes:

Fixes #1892

Testing

go test -run=TestJaroWinkler

Release Notes

(REQUIRED)

yigithankarabulut commented 2 months ago

Probably the rate limit was reached in the check and failed. The remaining steps were therefore canceled.

avorima commented 1 month ago

Please run go mod tidy to remove the dependency completely

meatballhat commented 1 month ago

Sorry about the trouble with codecov 😩 I'll get a token set up as soon as I can!

Update: it's already set up, but I'm assuming the token expired (??) Anyway, I updated it and now I'll re-run the failed checks.

Update Update: Uhhhh the token is updated and appears to be in use, and we're still getting rate limit failure. I think the failing step should probably get a continue-on-error: true

Update 3x: #1898

yigithankarabulut commented 1 month ago

@meatballhat You can be sure there will be more to come. Let's go!

bartekpacia commented 1 month ago

Go go go! :D