search

urfave / cli

A simple, fast, and fun package for building command line apps in Go
https://cli.urfave.org
MIT License
21.89k stars 1.69k forks source link

Update GitHub Actions (bump versions, improve naming a bit) #1895

Closed bartekpacia closed 1 month ago

bartekpacia commented 1 month ago

What type of PR is this?

What this PR does / why we need it:

This PR updates all GitHub Actions we use to the latest versions. GitHub is phasing out Node.js 16 so actions have to be updated.

I also added the staticcheck linter, enabled. I've been using staticcheck for many years in my personal Go projects and it's a very useful tool. It also works great with golangci-lint.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Testing

This is a change related itself to testing.

Release Notes

None.

meatballhat commented 1 month ago

Sorry about the conflict, @bartekpacia!

bartekpacia commented 1 month ago

@meatballhat no problem, resolved it :)

bartekpacia commented 1 month ago

@meatballhat "diffcheck" is failing. I suppose the action here is to update godoc-current.txt, right? The changes in this PR are not breaking, it's just some receiver/args renaming)

meatballhat commented 1 month ago

@meatballhat "diffcheck" is failing. I suppose the action here is to update godoc-current.txt, right? The changes in this PR are not breaking, it's just some receiver/args renaming)

Yep this is a bit clunky, but meant to guard against accidentally doing something not-semver. You can run make v3approve and commit + push the change if it looks good to you 👍🏼