search

urfave / cli

A simple, fast, and fun package for building command line apps in Go
https://cli.urfave.org
MIT License
21.91k stars 1.69k forks source link

fix: disable bash completion if double dash is included in arguments (v2) #1938

Closed suzuki-shunsuke closed 3 days ago

suzuki-shunsuke commented 4 days ago

What type of PR is this?

(REQUIRED)

What this PR does / why we need it:

(REQUIRED)

This pull request disables shell completion if double dash -- is included in arguments. Arguments after double dash -- are not flags but positional arguments.

https://unix.stackexchange.com/a/11382

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #1932

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

Release Notes

(REQUIRED)

suzuki-shunsuke commented 4 days ago

This pull request is for urfave/cli v2.

dearchap commented 3 days ago

@suzuki-shunsuke Thank you for the PR. Can you make this PR for v3 as well ?

suzuki-shunsuke commented 3 days ago

Can you make this PR for v3 as well ?