urfuwo / hlx-test

Apache License 2.0
0 stars 3 forks source link

449: Hero spacing issues #450

Closed rjwtrmn closed 5 months ago

rjwtrmn commented 5 months ago

Fix #449

Test URLs: Design Page with hero margin issue

L3

L2

L1

aem-code-sync[bot] commented 5 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [f119e9a](https://github.com/urfuwo/hlx-test/commit/f119e9a16ef0dd6a11af738d443d9f5547e77807) :white_check_mark: (latest) * [572e8bc](https://github.com/urfuwo/hlx-test/commit/572e8bcf5304f19dc955603348a2fae0391f12ae) :white_check_mark: * [b349044](https://github.com/urfuwo/hlx-test/commit/b3490449873f3de79ab2c4b9cf18aadd8025c42d) :white_check_mark: * [d1bd82a](https://github.com/urfuwo/hlx-test/commit/d1bd82a4ad1145871405a76ccdc80e69d7ae35b3) :white_check_mark:
aem-code-sync[bot] commented 5 months ago
Page Scores Audits Google
/blog/ext-how-ai-powered-cybersecurity-combats-ai-threats PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/design/stories-resources PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/topics PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/topics/sustainability PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
rjwtrmn commented 5 months ago

Sorry, please check why the score dropped for /design/stories-resources Is a CLS detected? Also is this caused by this PR?

I am not sure, seems there is some CLS when the featured article is rendered but not any more so than on main, and the lighthouse score seemed ok when I checked (97 performance) https://pagespeed.web.dev/analysis/https-449-hero-bottom-margin--hlx-test--urfuwo-hlx-live-design-stories-resources/xat59t7eev?form_factor=mobile

saurabh-khare commented 5 months ago

Sorry, please check why the score dropped for /design/stories-resources Is a CLS detected? Also is this caused by this PR?

I am not sure, seems there is some CLS when the featured article is rendered but not any more so than on main, and the lighthouse score seemed ok when I checked (97 performance) https://pagespeed.web.dev/analysis/https-449-hero-bottom-margin--hlx-test--urfuwo-hlx-live-design-stories-resources/xat59t7eev?form_factor=mobile

Ok I see the same when I manually run PSI. @mhaack Can there be some issue with PSI check?