urfuwo / hlx-test

Apache License 2.0
0 stars 3 forks source link

#484 Set * box-sizing to border-box #486

Closed eduardseifert closed 5 months ago

eduardseifert commented 5 months ago

Fix #484

Test URLs

aem-code-sync[bot] commented 5 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [4dacbe1](https://github.com/urfuwo/hlx-test/commit/4dacbe15d40daa258a7a0bfac32068270029764d) :white_check_mark: (latest) * [ccfa51d](https://github.com/urfuwo/hlx-test/commit/ccfa51d8b4ff5490f69c873a19774ca8ded9947f) :white_check_mark: * [4e51d48](https://github.com/urfuwo/hlx-test/commit/4e51d4886f821a1c68703e684b01309fb8198cce) :white_check_mark: * [98c211a](https://github.com/urfuwo/hlx-test/commit/98c211ae58219e74613dd0e0ced0deeaeb19815b) :white_check_mark:
aem-code-sync[bot] commented 5 months ago
Page Scores Audits Google
/design/design-system PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
alexcarol commented 5 months ago

The footer looks different:

Main: image PR: image

eduardseifert commented 5 months ago

@alexcarol I repaired all the occurences in the footer. Due to the changes to the box-sizing a few changes were made:

(1) Contact block

(2) Footer block

Icons are back in place. The main probs resulted in padding (content-box) vs margin (border-box).

eduardseifert commented 5 months ago

@rjwtrmn + @saurabh-khare Also please have a look on this. Due to the changes in box-sizing I had to update contact block and footer block (used the opportunity to rearange the styles).

eduardseifert commented 5 months ago

New PR in #495. Ignore this one.