urfuwo / hlx-test

Apache License 2.0
0 stars 3 forks source link

341: Picture cards fine alignment and styling tweaks #489

Closed rjwtrmn closed 5 months ago

rjwtrmn commented 5 months ago

Fix #341

Test URLs: Content Hub: Before: https://main--hlx-test--urfuwo.hlx.live/topics/ After: https://341-fine-alignment-on-picture-card--hlx-test--urfuwo.hlx.live/topics/

aem-code-sync[bot] commented 5 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [8779df4](https://github.com/urfuwo/hlx-test/commit/8779df41c6320408d5dbf2ea08ddf56573581a68) :white_check_mark: (latest)
aem-code-sync[bot] commented 5 months ago
Page Scores Audits Google
/topics/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
saurabh-khare commented 5 months ago
Screenshot 2024-04-19 at 09 57 31

The author info on the cards is not aligned https://341-fine-alignment-on-picture-card--hlx-test--urfuwo.hlx.page/draft/skhare/author-profiles-validation

saurabh-khare commented 5 months ago

As of now https://main--hlx-test--urfuwo.hlx.page/draft/skhare/author-profiles-validation

Screenshot 2024-04-19 at 09 59 14
rjwtrmn commented 5 months ago

The author info on the cards is not aligned https://341-fine-alignment-on-picture-card--hlx-test--urfuwo.hlx.page/draft/skhare/author-profiles-validation

@saurabh-khare From the designs in Figma I think this is the correct appearance, e.g. https://www.figma.com/file/oSetT4LbatRmXlcB2A7V8Z/Content-Hubs-2024?type=design&node-id=4918-193478&mode=design&t=0iW4LCPTylr2PEvh-0. To me it seems like the author info should always hug the bottom of the card and not be aligned in a row with the other cards, unless there is some info to the contrary from Elaine somewhere?

image

saurabh-khare commented 5 months ago
Screenshot 2024-04-19 at 14 57 57

Please fix this as well in same PR :)

rjwtrmn commented 5 months ago
Screenshot 2024-04-19 at 14 57 57

Please fix this as well in same PR :)

@saurabh-khare I created a new story for this which I will look at ASAP, the fix was getting a bit too involved for this PR as we probably have to tweak how top padding is applied to all sections https://github.com/urfuwo/hlx-test/issues/501